Email notifications are not localized and are always sent in English
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 12
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
How to use GitHub
- Please use the 👍 reaction to show that you are affected by the same issue.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Steps to reproduce
- Configure the user account, the resource account and the admin account with the same non-English language (French in my case).
- Create a room booking.
- Wait for the booking confirmation email.
Expected behaviour
The email subject and body should be sent in the recipient's configured language (French in my case), just like the RoomVox user interface.
Email notifications should use the existing Nextcloud localization (IL10N) system.
Actual behaviour
The booking confirmation email is always sent in English.
Example:
Subject
Booking confirmed: Room A — Test
Body
Your booking has been confirmed.
Room: Room A
Event: Test
...
Additional investigation
- RoomVox version: 1.2.1
- Nextcloud version: 33.0.4
- PHP version: 8.4.21
- All involved accounts (user, resource and admin) are configured in French.
- The RoomVox web interface is correctly translated into French.
- The project already contains translation files such as:
l10n/fr.jsonl10n/de.jsonl10n/nl.json
However, the email texts are hardcoded in:
lib/Service/MailService.php
For example:
return "Your booking has been confirmed.\n\n";
It looks like email notifications are not using the existing Nextcloud localization (IL10N) system.
Server configuration
Web server: Apache 2.4.67 (Debian)
Database: MariaDB
PHP version: 8.4.21
Nextcloud version: 33.0.4
RoomVox version: 1.2.1
Deployment: Docker
Browser
Not applicable (server-side email generation).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/Service/MailService.php, where the booking email subject and body are hardcoded in English, and compare it with the existing l10n/fr.json, l10n/de.json, and l10n/nl.json files. Check how the Nextcloud IL10N system can be used for these notifications and verify that both subject and body follow the recipient's configured language, including French.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend, localization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100