nextcloud-libraries / nextcloud-libraries/nextcloud-vue
[NcAppSettingsDialog] [NcAppNavigationItem] Redesign follow-ups
Nobody has claimed this yet.
- Dominant language
- Vue
- Stars
- 246
- Forks
- 99
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 103
Description
Some issues I noticed with #8477 and #8448 that should be fixed before the final release.
Navigation
The selected item is lighter, but the hovered one is darker (the other way around in dark mode). The selected item should also be darker, the same as in the settings dialog and like in the mockup.
Settings Dialog
- The close button is clipping with the content without a background. It should have one.
- :hover effects and the pill indicating selection on the sidebar don't animate.
- The pill is taller than in the regular navigation sidebar and (thus) clips into the border radii. It should look the same as for the regular navigation.
@nfebe
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting NcAppSettingsDialog and NcAppNavigationItem, then compare their navigation states with the attached mockups and regular navigation. Done means the selected and hovered colors, close-button background, hover and selection animations, and sidebar pill dimensions match the requested appearance.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- design, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100