nextcloud-libraries / nextcloud-libraries/nextcloud-vue
Hiding the description for width < 450 negatively impacts rendering in Talk
Nobody has claimed this yet.
- Dominant language
- Vue
- Stars
- 246
- Forks
- 99
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 103
Description
As implemented in Talk and discussed in this issue https://github.com/nextcloud/spreed/issues/17881, when the width for the embed widget is <450, the description is not shown due to the size of the widget. I am not familiar with this code so I can't estimate the impact of changing this for all downstream consumers this but for the use case in Talk, the description should not be hidden.
Relevant code:
Thank you and apologies in advance if this issue is not appropriate or if there are any errors as I'm not familiar with this codebase.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect src/components/NcRichText/NcReferenceWidget.vue around lines 75–92, starting with the width-based rendering logic for the embed widget. Check how the component is used by Talk and assess the existing component behavior at widths below 450. Done means the description remains visible for the Talk use case without breaking downstream consumers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100