nextcloud-libraries / nextcloud-libraries/nextcloud-vue
[NcActions] 'closed' event is not emmited in v9
Open
Nobody has claimed this yet.
- Dominant language
- Vue
- Stars
- 246
- Forks
- 99
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 103
Description
The closed event is not emitted when the popover menu created by NcActions is closed.
Steps to Reproduce
Given the following setup:
<template>
<NcActions @close="showMessage('Close')" @closed="showMessage('Closed')">
<NcActionButton @click="showMessage('Edit')"> Edit </NcActionButton>
<NcActionButton @click="showMessage('Delete')">Delete </NcActionButton>
</NcActions>
</template>
<script>
export default {
methods: {
showMessage(msg) {
alert(msg);
},
},
};
</script>
- Click on the menu indicator to open the popover
- Click outside the popover to close it
- (Observe the
closeevent being emitted in v8 and v9) - Observe the
closedevent- being emitted in v8
- not being emitted in v9
Actual Behavior
closed event is not emitted in v9.
Expected Behavior
closed event being emitted.
Environment
- Version
- for v9
- https://nextcloud-vue-components.netlify.app/
- or 1b50fda (recent commit on main at that time)
- for v8 https://stable8--nextcloud-vue-components.netlify.app
- for v9
- Browser
- Chrome 144
- Firefox 147
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the NcActions component and its popover close handling, then compare the v9 behavior with the v8 implementation or the linked reproduction. Verify that clicking outside the popover emits both close and closed, and confirm the fix with the provided Vue example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100