nextcloud-libraries / nextcloud-libraries/nextcloud-vue
[NcListItem] List items highlight on hover even when they don't do anything
Nobody has claimed this yet.
- Dominant language
- Vue
- Stars
- 246
- Forks
- 99
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 103
Description
I'm not sure I fully understand the underlying behavior, but the outcome is certainly unexpected as a user (of apps):
Some list items do nothing when clicked (eg. items in "Always show images from" in Mail). They only exist to display other actions (like Delete). However, they still highlight and change the cursor to a pointer on hover:
The item should only highlight in such a way if clicking on it does something. Not sure if this would be breaking existing behavior people rely on, or if this is something applications can already control somehow, but it should be fixed.
This also seems to not be the case with NcListItemIcon, but not sure.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the NcListItem implementation and compare its hover, cursor, and click behavior with NcListItemIcon. Reproduce the non-actionable list item case described in the issue, then verify that items without an action no longer highlight or show a pointer while actionable items retain their behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100