nextcloud-libraries / nextcloud-libraries/nextcloud-vue
NcReferenceWidget generates warnings on destroy
Nobody has claimed this yet.
- Dominant language
- Vue
- Stars
- 246
- Forks
- 99
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 103
Description
Warning context:
Should be this line (although there's a void function set as a fallback, so can't get why it generates such warning):
https://github.com/nextcloud-libraries/nextcloud-vue/blob/f72035078469e18c44f57c09bd8803b63efa3b54/src/functions/reference/widgets.ts#L90
Optional calling doesn't help either (i = window._vue_richtext_widgets[richObjectType].onDestroy:
window._vue_richtext_widgets[richObjectType]?.onDestroy?.(el)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting src/functions/reference/widgets.ts at line 90 and reproduce the warning shown in the issue when NcReferenceWidget is destroyed. Trace the onDestroy call and determine what behavior should prevent the warning; done means destroying the widget no longer emits it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100