nextcloud-libraries / nextcloud-libraries/nextcloud-vue
Status icon has visible border instead of depending on background
Nobody has claimed this yet.
- Dominant language
- Vue
- Stars
- 246
- Forks
- 99
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 103
Description
The status icon border/background currently is always set to color-main-background. This means that in light theme, it is always white. On other backgrounds like in the header or in various states like hovered/focused/active/selected it looks off.
Just like with other icons such as the favorite overlay in the files list, it is intended to create a slight gap between the icon and the element it overlays – not to be a visible border.
This occurs in various places, here are some examples:
Top right account menu
The status of the top right avatar. Granted this depends on the theming background, but we can at least solve it for the default installation, and possibly even for the shipped themes.
File sharing sidebar
The selected suggestion has a grey background, but is not the same for the status border. Additionally, the status icon seems to be cut off a bit, leading to the crescent shape being barely recognizable?
Talk navigation
In the default state it is a bit difficult to set a border which fits the background since we have the glass look and the variable background. But in hover/focus and active state we know what the background is.
Talk @-mention suggestions
The status icon of the active/selected person should be adjusted to get a border that matches the background of the selected entry.
Deck assignments
Similar as in other examples, the status for the selected entry would look nicer with the color adjusted. Additionally, in the input field the same issue as in Files happens where the status icon is somehow cut off:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the status icon component and the color-main-background border/background rule, then compare its behavior with the favorite overlay in the files list. Check the account menu, file sharing, Talk, and Deck examples across default and selected, hovered, focused, and active states; done means the gap is not a visible border and the icon is not cut off.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- design, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100