nextcloud-libraries / nextcloud-libraries/nextcloud-vue
NcAppNavigationItem undo has several issues
Nobody has claimed this yet.
- Dominant language
- Vue
- Stars
- 246
- Forks
- 99
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 103
Description
When setting undo = true:
the text overflow is broken
The overflow of the name isn't hidden anymore, the name can overflow into the content and other elements like the actions are pushed into a second line.
the undo action has no label
There doesn't appear to be any way to set a label for the undo action that is created. This is fine if undo is the only action and forceMenu & editable are false but suboptimal if there happens to be a actions menu.
the icon disappears
The icon disappears for no apparent reason.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the NcAppNavigationItem component and reproduce the behavior with undo=true, checking the text overflow, undo action labeling, and icon rendering. Done means the name stays within its layout, the undo action can have a label, and the icon remains visible.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100