nextcloud-libraries / nextcloud-libraries/nextcloud-vue
Make aria-label mandatory for buttons
Nobody has claimed this yet.
- Dominant language
- Vue
- Stars
- 246
- Forks
- 99
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 103
Description
We've logged a warning for a while
You need to fill either the text or the ariaLabel props in the button component
I think it would be fair to start enforcing this prop in a future major version.
Ref https://github.com/nextcloud/nextcloud-vue/commit/d441b9dfb47aebae17bae4c21493057e4a7c862c @marcoambrosini
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the button component and review the existing warning about the text and ariaLabel props, using the referenced commit for context. Done means the required accessibility prop is enforced as proposed for the next major version, with the component's existing behavior and validation covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- accessibility, frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100