nextcloud-libraries / nextcloud-libraries/nextcloud-vue
error if linkAutocomplete or emojiAutocomplete are disabled
Nobody has claimed this yet.
- Dominant language
- Vue
- Stars
- 246
- Forks
- 99
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 103
Description
If one of the options are disabled we shouldn't try to get the state "isActive" anymore. This throws errors because this.autocompleteTribute is undefined:
https://github.com/nextcloud/nextcloud-vue/blob/a4e9aff53eb86b79c3f0786488ab422403d22bff/src/components/NcRichContenteditable/NcRichContenteditable.vue#L633
My vue try:
<NcRichContenteditable
:value.sync="localValue"
:auto-complete="autoComplete"
:user-data="operators"
:placeholder="t('tables', 'Search and filter')"
:emoji-autocomplete="false"
:link-autocomplete="false"
@submit="onSubmit" />
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/components/NcRichContenteditable/NcRichContenteditable.vue at the linked line around 633, where isActive is read from autocompleteTribute. Reproduce the configuration with emoji-autocomplete and link-autocomplete disabled, then verify that the component no longer throws when either option is false.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100