nextcloud-libraries / nextcloud-libraries/nextcloud-vue

URL pattern only accepts urls with domain

Open
#3,930 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
Vue
Stars
246
Forks
99
Avg merge
1d 20h
Merged PRs (30d)
103

Description

the smart widget validation is using this URL pattern to decide if a URL should be send to the resolver.

https://github.com/nextcloud/nextcloud-vue/blob/af25af897a22410fc04cdbb140253cc3c28b520e/src/components/NcRichText/helpers.js#L1

used here
https://github.com/nextcloud/nextcloud-vue/blob/0390767fb52de625655f2bc5b255028495945986/src/components/NcRichText/NcReferenceList.vue#L67

my setup is within a local docker and this does not have a domain like .com - so the resolver is never triggered for local urls.
Is this on purpose or should it be made more flexible?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the URL pattern in src/components/NcRichText/helpers.js at line 1, then inspect its use in src/components/NcRichText/NcReferenceList.vue at line 67. Reproduce the behavior with a local URL in the Docker setup and determine whether the resolver is expected to accept URLs without a public domain. Done means the intended local-URL behavior is implemented and verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.