nextcloud-libraries / nextcloud-libraries/nextcloud-vue
Treat 1024px width as not mobile everywhere
Nobody has claimed this yet.
- Dominant language
- Vue
- Stars
- 246
- Forks
- 99
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 103
Description
In some places we treat a screen of width 1024 as mobile - in others it's the smallest that's not treated as mobile.
Following up on #3768 also change the following css styles to not apply to 1024px / or 512 px. respectively:
https://github.com/nextcloud/nextcloud-vue/blob/8342cda8a128da49b421bd24edf3b1c928a152c6/src/components/NcAppNavigation/NcAppNavigation.vue#L189-L196
and
https://github.com/nextcloud/nextcloud-vue/blob/c80a585a2eef2bd1057917271c1ce0d2dabd02a6/src/components/NcModal/NcModal.vue#L936
and
https://github.com/nextcloud/nextcloud-vue/blob/c53599ed09b68d1e00c134c0fc2405848c162548/src/components/NcAppSidebar/NcAppSidebar.vue#L881
Originally posted by @raimund-schluessler in https://github.com/nextcloud/nextcloud-vue/issues/3768#issuecomment-1432984944
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the linked responsive styles in NcAppNavigation.vue, NcModal.vue, and NcAppSidebar.vue, starting with the referenced lines and the breakpoint behavior from #3768. Verify the affected components at 1024px and 512px widths; done means those widths consistently use the non-mobile behavior described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css
- Domain
- frontend, web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100