nextcloud-libraries / nextcloud-libraries/nextcloud-vue
Keep popup open when no match is found in NcRichContenteditable
Nobody has claimed this yet.
- Dominant language
- Vue
- Stars
- 246
- Forks
- 99
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 103
Description
Currently, when there is no match, the pop-up is not displayed, so the user does not know that he is still triggering tribute. Which means that when he presses enter, it will trigger tribute without knowing it.
I think it is best to keep the popup displayed, so the user is not lost.
Achievable with something like:
noMatchTemplate: `<div>${translate("No comments")}</div>`
@jancborchardt or @nimishavijay
Originally posted by @artonge in https://github.com/nextcloud/nextcloud-vue/pull/3468#pullrequestreview-1183980708
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search for the NcRichContenteditable component and its Tribute configuration; the issue suggests using noMatchTemplate with a translated “No comments” message. Confirm the popup remains visible when there is no match and that pressing Enter still behaves as expected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100