nextcloud-libraries / nextcloud-libraries/nextcloud-vue
Standardize how the sidebar is shown next to the modal
Nobody has claimed this yet.
- Dominant language
- Vue
- Stars
- 246
- Forks
- 99
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 103
Description
From https://github.com/nextcloud/server/pull/33568#discussion_r956676324
Maybe we should add some kind of automated watcher in the content or something? Maybe a MutationObserver or something?
There might be people using their own Sidebar for example, not only the Files Sidebar :)
Maybe that should just be in the vue components?
Also, if we could, I would be up using data attributes for such targets now, like @nextcloud/cypress is doing. Something like data-app-content.
Would be relevant for viewer+files sidebar but might also be for Talk.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the linked PR discussion and the Vue components involved in showing the sidebar beside the modal. Compare the suggested MutationObserver approach with component-level handling and data attributes such as data-app-content, considering viewer, Files Sidebar, and Talk use cases. Done should mean an agreed, reusable standard with its scope and behavior defined.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100