nextcloud-libraries / nextcloud-libraries/nextcloud-vue
Remove icon class support for Actions
Open
Nobody has claimed this yet.
💥 breaking
technical debt
- Dominant language
- Vue
- Stars
- 246
- Forks
- 99
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 103
Description
This will be a breaking change because all apps and server will have to switch to Vue icons.
Probably it's best to first deprecate this somehow and start removing once most of the migration is done already.
Ref https://github.com/nextcloud/nextcloud-vue/pull/3006
- remove icon class support for single action item
- remove icon class support on actionText mixin
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing pull request 3006 and locating the single action item implementation and the actionText mixin. Confirm how icon classes are currently supported and how deprecation should precede removal. Done means both checklist items are addressed without breaking the migration to Vue icons.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100