nextcloud-libraries / nextcloud-libraries/nextcloud-vue
AppNavigation is still traversable when closed
Nobody has claimed this yet.
- Dominant language
- Vue
- Stars
- 246
- Forks
- 99
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 103
Description
When the AppNavigation is closed it is moved outside of the viewport. However, its contents are still in the DOM and, technically, visible, so they are still focusable and pressing tab traverses them.
Note that the AppNavigation as a whole can not be hidden when closed, as the toggle to show it again is also part of it; only the list and the footer should be hidden.
Steps to reproduce
- Open Talk or Mail
- Close the app navigation
- Traverse the UI pressing tab
Expected result
The button to toggle the navigation bar is traversed, but nothing else from the AppNavigation is
Actual result
The contents of the navigation bar are traversed
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/components/AppNavigation/AppNavigation.vue, especially the closed-state handling around lines 165-168 and the toggle around line 61. Reproduce the issue in Talk or Mail by closing the navigation and pressing Tab. Done means the toggle remains traversable while the closed navigation contents are not.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100