nextcloud-libraries / nextcloud-libraries/nextcloud-vue
ActionInput: Fix documentation or add `inheritAttrs: true`
Nobody has claimed this yet.
- Dominant language
- Vue
- Stars
- 246
- Forks
- 99
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 103
Description
ActionInput has inheritAttrs: false but tries to inherit attrs. Either add inheritAttrs: true or change the documentation.
Take a look at the second sentence of the documentation of ActionLink. Currently, it is not entirely true as inheritAttrs is false:
All undocumented attributes will be bound to the input, the datepicker or the multiselect component, e.g. maxlength, not-before.
Originally posted by @tcitworld in https://github.com/nextcloud/nextcloud-vue/issues/2472#issuecomment-1030107397
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the ActionInput component and the second sentence of the ActionLink documentation, focusing on the documented handling of undocumented attributes and the current inheritAttrs setting. Confirm which behavior is intended, then make the documentation and implementation agree and verify the relevant component documentation or tests if present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100