nextcloud-libraries / nextcloud-libraries/nextcloud-vue
Add "isFullScreen" property to "AppSidebar" component
Nobody has claimed this yet.
- Dominant language
- Vue
- Stars
- 246
- Forks
- 99
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 103
Description
In Nextcloud 22 the isFullScreen property was added to the Sidebar component of the Files app, and now when the viewer is opened the sidebar is set in full screen mode.
Due to this it could be good to move the isFullScreen property from the Sidebar component of the Files app to the AppSidebar component in nextcloud-vue. This way other apps using the viewer can just enable or disable the full screen mode in their sidebar component by delegating on the parent AppSidebar without having to provide their own CSS rules.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked Files app Sidebar change and viewer's Viewer.vue entry point at line 369, then locate the AppSidebar component in nextcloud-vue. Check how the existing full-screen property is delegated and identify the component tests. Done means other viewer-using apps can enable or disable sidebar full-screen mode through AppSidebar without custom CSS.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100