nextcloud-libraries / nextcloud-libraries/nextcloud-vue

AppNavigationCaption / Caption

Open
#1,751 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0. to triage component discussion
Dominant language
Vue
Stars
246
Forks
99
Avg merge
1d 20h
Merged PRs (30d)
103

Description

We currently have 2 components that do the same thing in the navigation. As said in today's components call we should chose one and go forward with it In all instances. Personally I would go with the talk version with slightly more padding on the left as done here https://github.com/nextcloud/nextcloud-vue/pull/1740#issue-585470701.
cc @nextcloud/designers

Talk version: Caption
Screenshot from 2021-03-09 10-56-22

Admin settings version AppNavigationCaption
Screenshot from 2021-03-09 10-55-41

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the Caption and AppNavigationCaption components and reviewing the linked pull request #1740 for the preferred Talk styling. Search their usages across the repository, then consolidate navigation instances on one component with the requested left padding; done means the duplicate component is no longer needed and all navigation captions are consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.