nextcloud-libraries / nextcloud-libraries/nextcloud-vue
Apply box-sizing:border-box globally
Nobody has claimed this yet.
- Dominant language
- Vue
- Stars
- 246
- Forks
- 99
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 103
Description
Follow up to #1361.
@skjnldsv
Iwonder if that wouldn't make sense to apply this to the whole actions component with the * selector. I thought I saw a comment about this somewhere, but can't find it.
If we want to be as independent from server's styling as possible, this might be better thinking
@raimund-schluessler
If we have it globally, we could also get rid of this https://github.com/nextcloud/nextcloud-vue/blob/master/tests/visual/components/AppSidebar/AppSidebar.visual.js#L40-L49 and this https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/Content/Content.vue#L73-L75, I think.
Last question to @tcitworld was:
what do you think?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading issue #1361 and inspect the referenced visual test at tests/visual/components/AppSidebar/AppSidebar.visual.js and the override in src/components/Content/Content.vue. Determine the intended global styling scope and whether those existing references can be removed; done means the decision is implemented consistently and the affected visual checks still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100