nextcloud-libraries / nextcloud-libraries/nextcloud-upload

MKCOL for batch upload does not work with special characters

Open
#1,964 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
10
Forks
5
Avg merge
2d 10h
Merged PRs (30d)
14

Description

Seems like we miss encoding of # in URLs.

Reproduce:

  • create folder foo#bar
  • go into that folder
  • try to upload a whole folder
  • see that the request targets /foo/new-folder instead of /foo#bar/new-folder

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the batch-upload request for a folder named foo#bar, then trace where the MKCOL URL is constructed and encoded. Confirm that the request targets the folder path with the # preserved as encoded URL data, and rerun the batch-upload reproduction to verify the request path.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.