nextcloud-libraries / nextcloud-libraries/nextcloud-upload
Response status codes are not handled in the server, because the upload response is null
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 10
- Forks
- 5
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 14
Description
I noticed that the web frontend doesn't handle errors like 507, because in https://github.com/nextcloud/server/blob/a9635044e35dadc0065889f62801173ad190863f/apps/files/src/views/FilesList.vue#L719-L719 the upload.response is just null.
To reproduce, just set a quota for the account and then upload a new file that would make the total storage usage go over the allowed quota. I only tested this with chunked uploads, so it could be specific to that.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with FilesList.vue at the linked line and reproduce a quota-exceeding chunked upload to inspect why upload.response is null. Trace the upload response through the nextcloud-upload library; done means the frontend receives the server status, including 507, so it can handle the error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- full-stack
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100