nextcloud-libraries / nextcloud-libraries/nextcloud-upload
Conflict dialog improvements
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 10
- Forks
- 5
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 14
Description
Originally reported by @marcoambrosini in https://github.com/nextcloud/server/issues/50746
Team, I would suggest some improvements for this popup, as for me it is not so immediate which checkbox to select.
Things I would do to start improving it are:
- To emphasize more the question "Which files do you want to keep?" instead of the path which is not so relevant.
2.Once the new file is selected, change the button label to "Overwrite" or "replace".
Looping @tobiasKaminsky since the mobile version is similar.
Additional points:
- We could also put the "If you select ... be overwritten." text into an info callout component.
- Title of the dialog could be "[n] file conflicts, which files do you want to keep?"
- The path could be in a simple p element just above the callout
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the conflict dialog implementation in this TypeScript upload library and compare its current labels, question emphasis, path placement, and callout treatment with the issue screenshot. Confirm the desired wording and scope with maintainers before changing the UI; done means the dialog clearly asks which files to keep and uses the requested replacement label.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100