nextcloud-libraries / nextcloud-libraries/nextcloud-dialogs
Forward the offset options
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- TypeScript
- Stars
- 19
- Forks
- 8
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 37
Description
See https://github.com/apvarun/toastify-js/blob/master/README.md#add-some-offset
Would be useful to offset the notification in case it overlaps with other controls like a top bar, see https://github.com/nextcloud/spreed/pull/5794
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Toastify.js README section on adding offsets and inspect the dialog helper API in this repository to find where notification options are passed. Done means the offset options described there can be forwarded so notifications can avoid overlapping controls, as illustrated by the linked Nextcloud Spreed pull request.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100