nextauthjs / nextauthjs/next-auth

signIn with redirect: false returns invalid response on error

Open
#6,040 2 comments 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

triage
Dominant language
TypeScript
Stars
28.4k
Forks
4k
PR merge metrics
No merged PRs in 30d

Description

Environment

System:
OS: macOS 13.0.1
CPU: (10) arm64 Apple M1 Pro
Memory: 101.13 MB / 32.00 GB
Shell: 3.5.1 - /opt/homebrew/bin/fish
Binaries:
Node: 16.18.1 - ~/.local/share/nvm/v16.18.1/bin/node
npm: 9.2.0 - ~/.local/share/nvm/v16.18.1/bin/npm
Browsers:
Chrome: 108.0.5359.98
Firefox: 107.0.1
Safari: 16.1
Safari Technology Preview: 16.4
npmPackages:
next: ^13.0.6 => 13.0.6
next-auth: ^4.18.6 => 4.18.6
react: ^18.2.0 => 18.2.0

Reproduction URL

https://codesandbox.io/s/beautiful-heisenberg-myfm11?file=/pages/auth/signin.tsx

Describe the issue

signIn method with { redirect: false } and invalid credentials produces an invalid response:

{
  error: "CredentialsSignin",
  ok: true,
  status: 200,
  url: null
}

According to docs (https://next-auth.js.org/getting-started/client#using-the-redirect-false-option), response should be

   error: "CredentialsSignin",
   ok: false,
   status: 401,
   url: null

This seems to break with 4.18.1 version, 4.18.0 is fine.

How to reproduce
  • Include a credentials provider and return null from authorize callback.
  • Call const response = await signIn('cred_test', { username: 'invalid', password: 'invalid', redirect: false, callbackUrl: '/})
  • Check the response: {error: "CredentialsSignin", status: 200, ok: true, url: null}
Expected behavior

Response should include {error: "CredentialsSignin", status: 401, ok: false, url: null}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked CodeSandbox and the signIn call in pages/auth/signin.tsx, using invalid credentials with redirect: false. Compare the behavior between next-auth 4.18.0 and 4.18.1. Done means the response matches the documented error shape with ok false, status 401, error CredentialsSignin, and url null.

Written by the indexing model from the issue text.

Assessment

Tech stack
next.js, react, typescript
Domain
authentication
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.