next-exp / next-exp/IC

`hits_and_kdst_from_files()` fails silently

Open
#956 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
11
Forks
77
PR merge metrics
No merged PRs in 30d

Description

The function hits_and_kdst_from_files() found here is designed to continue if the required tables aren't found in the file it's extracting from when using load_dst().

This stems from the general treatment of the NoSuchNodeError, which is treated differently across all of IC on a case-by-case basis, but is regularly ignored as can be seen throughout components.py for multiple functions.

I don't believe this should be the case, but I'm glad to be told otherwise. It at the very least should warn the user that the node they were trying to access doesn't exist. This is seen in load_dst when ignore_errors = True (here), but this is by default False.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with hits_and_kdst_from_files() in invisible_cities/cities/components.py and load_dst() in invisible_cities/io/dst_io.py, then compare the project’s existing NoSuchNodeError handling in components.py. The behavior should no longer fail silently when required tables are missing; determine and verify the appropriate warning or error handling across the affected cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.