Review tests in `psf_functions_test.py`
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 11
- Forks
- 77
- PR merge metrics
- No merged PRs in 30d
Description
... specifically
test_add_empty_sensors_and_normalize_qtest_add_empty_sensors_and_normalize_q_filetest_hdst_psf_processing
The input data for these tests is not the expected one. We expect hits that correspond to one z-sample and one sensor. Because these tests only check for continuity, we've never noticed they are incorrect.
We should also add more meaningful tests.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading psf_functions_test.py and the named tests: test_add_empty_sensors_and_normalize_q, test_add_empty_sensors_and_normalize_q_file, and test_hdst_psf_processing. Inspect their input data and current continuity checks, then run the tests to confirm the mismatch. Done means the tests use hits for one z-sample and one sensor and include meaningful coverage of the intended behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100