next-exp / next-exp/IC

Filter events where energy correction is not possible?

Open
#732 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
11
Forks
77
PR merge metrics
No merged PRs in 30d

Description

Hi there,

there are some events arribing at Beersheba that have all Ec values as NaN. This is a bit troublesome for beersheba as it applies deconvolution properly (just uses Q values) but ends up assigning energy as 0 when using the Ec values. Thing is, what do we do with these events. I guess they are not useful anyway (as they escape the correction map validity region) but I'm unsure how to proceed:

  1. Should we just flag them at the end of esmeralda with some table or label that indicates this or just leave the user to be smart enough to disregard them?
  2. Add a filter in beersheba before deconvolution runs so those events are not considered?

I'm guessing two should be added, anyway, as a sanity check but the implementation shall change depending on whether we want to do option 1 or not.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how Beersheba handles events whose Ec values are NaN and how Esmeralda currently exposes their results. Resolve whether these events should be filtered before deconvolution, flagged for users, or both; done means the chosen behavior is specified and the affected event path has a sanity check.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.