newrelic / newrelic/newrelic-java-agent
Add new `jdbc-ojdbc-tns` instrumentation module for `com.oracle.database.jdbc:ojdbc8:23.2.0.0`+
Open
Nobody has claimed this yet.
feature request
- Dominant language
- Java
- Stars
- 240
- Forks
- 170
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 21
Description
The existing jdbc-ojdbc-tns instrumentation was capped up to, but not including, com.oracle.database.jdbc:ojdbc8:23.2.0.0.
We should add a new jdbc-ojdbc-tns module to support com.oracle.database.jdbc:ojdbc8:23.2.0.0+.
11: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':instrumentation:jdbc-ojdbc-tns:verifyPass_com.oracle.database.jdbc_ojdbc8_23.2.0.0'.
> A failure occurred while executing com.newrelic.agent.instrumentation.verify.VerifyWorkAction
> Verification FAILED. Instrumentation module jdbc-ojdbc-tns-1.0.jar SHOULD HAVE applied to com.oracle.database.jdbc:ojdbc8:23.2.0.0 and did not. You may need to adjust the range "com.oracle.database.jdbc:ojdbc8:[0,)".
Verifier output:
Creating user classloader with custom classpath:
/Users/jkeller/.gradle/caches/modules-2/files-2.1/com.oracle.database.jdbc/ojdbc8/23.2.0.0/49acfb33ee776e43d2085e2fcc838778202a9128/ojdbc8-23.2.0.0.jar
WeaveViolation{type=MISSING_ORIGINAL_BYTECODE, clazz=oracle/net/ns/Packet}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in instrumentation/jdbc-ojdbc-tns and inspect the existing module configuration and version range. Run verifyPass_com.oracle.database.jdbc_ojdbc8_23.2.0.0 to reproduce the missing oracle/net/ns/Packet instrumentation. Done means the new module applies successfully to ojdbc8 23.2.0.0 and later without breaking existing verification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- databases
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100