newrelic / newrelic/newrelic-java-agent

Add instrumentation for org.apache.solr:solr-core 10.0.0+

Open
#2,787 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
240
Forks
170
Avg merge
3d 2h
Merged PRs (30d)
21

Description

The solr-7.0.0 instrumentation module stopped verifying for the new release of org.apache.solr:solr-core:10.0.0.

We need to add a new solr-10.0.0 instrumentation module.

* What went wrong:
Execution failed for task ':instrumentation:solr-7.0.0:verifyPass_org.apache.solr_solr-core_10.0.0'.
> A failure occurred while executing com.newrelic.agent.instrumentation.verify.VerifyWorkAction
   > Verification FAILED. Instrumentation module solr-7.0.0-1.0.jar SHOULD HAVE applied to org.apache.solr:solr-core:10.0.0 and did not. You may need to adjust the range "org.apache.solr:solr-core:[7.0.0,)".
     Verifier output:

     ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=org/apache/solr/client/solrj/impl/HttpSolrClient, originalClass=org/apache/solr/client/solrj/ResponseParser, violationMessage=Could not find resource}
     ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=org/apache/solr/client/solrj/SolrClient, originalClass=org/apache/solr/client/solrj/StreamingResponseCallback, violationMessage=Could not find resource}
     ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=org/apache/solr/client/solrj/impl/HttpSolrClient$Builder, originalClass=org/apache/solr/client/solrj/impl/SolrClientBuilder, violationMessage=Could not find resource}
     WeaveViolation{type=MISSING_ORIGINAL_BYTECODE, clazz=org/apache/solr/client/solrj/impl/HttpSolrClient}
     WeaveViolation{type=MISSING_ORIGINAL_BYTECODE, clazz=org/apache/solr/client/solrj/impl/HttpSolrClient$Builder}
     WeaveViolation{type=METHOD_NEW_INVOKE_UNSUPPORTED, clazz=org/apache/solr/client/solrj/SolrClient, method=queryAndStreamResponse(Ljava/lang/String;Lorg/apache/solr/common/params/SolrParams;Lorg/apache/solr/client/solrj/StreamingResponseCallback;)Lorg/apache/solr/client/solrj/response/QueryResponse;}
     WeaveViolation{type=METHOD_NEW_CALL_ORIGINAL_UNSUPPORTED, clazz=org/apache/solr/client/solrj/SolrClient, method=queryAndStreamResponse(Ljava/lang/String;Lorg/apache/solr/common/params/SolrParams;Lorg/apache/solr/client/solrj/StreamingResponseCallback;)Lorg/apache/solr/client/solrj/response/QueryResponse;}
     WeaveViolation{type=METHOD_NEW_NON_PRIVATE_UNSUPPORTED, clazz=org/apache/solr/client/solrj/SolrClient, method=queryAndStreamResponse(Ljava/lang/String;Lorg/apache/solr/common/params/SolrParams;Lorg/apache/solr/client/solrj/StreamingResponseCallback;)Lorg/apache/solr/client/solrj/response/QueryResponse;}
     WeaveViolation{type=METHOD_NEW_INVOKE_UNSUPPORTED, clazz=org/apache/solr/client/solrj/SolrClient, method=queryAndStreamResponse(Lorg/apache/solr/common/params/SolrParams;Lorg/apache/solr/client/solrj/StreamingResponseCallback;)Lorg/apache/solr/client/solrj/response/QueryResponse;}
     WeaveViolation{type=METHOD_NEW_CALL_ORIGINAL_UNSUPPORTED, clazz=org/apache/solr/client/solrj/SolrClient, method=queryAndStreamResponse(Lorg/apache/solr/common/params/SolrParams;Lorg/apache/solr/client/solrj/StreamingResponseCallback;)Lorg/apache/solr/client/solrj/response/QueryResponse;}
     WeaveViolation{type=METHOD_NEW_NON_PRIVATE_UNSUPPORTED, clazz=org/apache/solr/client/solrj/SolrClient, method=queryAndStreamResponse(Lorg/apache/solr/common/params/SolrParams;Lorg/apache/solr/client/solrj/StreamingResponseCallback;)Lorg/apache/solr/client/solrj/response/QueryResponse;}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the existing instrumentation/solr-7.0.0 module with the verifier failure for org.apache.solr:solr-core:10.0.0. Review the reported SolrClient, HttpSolrClient, and builder bytecode violations, then verify the new solr-10.0.0 module against the same dependency and confirm the instrumentation verification task passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.