newrelic / newrelic/newrelic-java-agent

New Module: servlet-user-5.0 for v6.2.0+

Open
#2,528 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
240
Forks
170
Avg merge
3d 2h
Merged PRs (30d)
21

Description

Description

Probably worth validating that the failure still exists once the non-milestone artifact is released.

Execution failed for task ':instrumentation:servlet-user-5.0:verifyPass_jakarta.servlet_jakarta.servlet-api_6.2.0-M1'.

A failure occurred while executing com.newrelic.agent.instrumentation.verify.VerifyWorkAction
Verification FAILED. Instrumentation module servlet-user-5.0-1.0.jar SHOULD HAVE applied to jakarta.servlet:jakarta.servlet-api:6.2.0-M1 and did not. You may need to adjust the range "jakarta.servlet:jakarta.servlet-api:[5.0.0,)".
Verifier output:
Creating user classloader with custom classpath:
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=jakarta/servlet/Servlet, originalClass=jakarta/servlet/http/HttpServletRequest, violationMessage=Could not find resource}
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=jakarta/servlet/Filter, originalClass=jakarta/servlet/FilterChain, violationMessage=Could not find resource}
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=jakarta/servlet/Servlet, originalClass=jakarta/servlet/ServletResponse, violationMessage=Could not find resource}
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=jakarta/servlet/Servlet, originalClass=jakarta/servlet/ServletRequest, violationMessage=Could not find resource}
WeaveViolation{type=MISSING_ORIGINAL_BYTECODE, clazz=jakarta/servlet/Servlet}
WeaveViolation{type=MISSING_ORIGINAL_BYTECODE, clazz=jakarta/servlet/Filter}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the instrumentation/servlet-user-5.0 module and the verifyPass_jakarta.servlet_jakarta.servlet-api_6.2.0-M1 task shown in the failure. Check the dependency range and reproduce verification against the released Jakarta Servlet artifact; the work is done when servlet-user-5.0 applies successfully to version 6.2.0 and the missing-bytecode violations are gone.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.