newrelic / newrelic/newrelic-java-agent
New module: servlet-6.0 for v6.2.0+
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 240
- Forks
- 170
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 21
Description
Description
Probably worth validating that the failure still exists once the non-milestone artifact is released.
Execution failed for task ':instrumentation:servlet-6.0:verifyPass_jakarta.servlet_jakarta.servlet-api_6.2.0-M1'.
A failure occurred while executing com.newrelic.agent.instrumentation.verify.VerifyWorkAction
Verification FAILED. Instrumentation module servlet-6.0-1.0.jar SHOULD HAVE applied to jakarta.servlet:jakarta.servlet-api:6.2.0-M1 and did not. You may need to adjust the range "jakarta.servlet:jakarta.servlet-api:[6.0.0,)".
Verifier output:
Creating user classloader with custom classpath:
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=com/nr/instrumentation/servlet6/ServletHelper, originalClass=jakarta/servlet/ServletContext, violationMessage=Could not find resource}
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=com/nr/instrumentation/servlet6/NRRequestWrapper, originalClass=jakarta/servlet/http/HttpServletRequest, violationMessage=Could not find resource}
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=jakarta/servlet/Filter, originalClass=jakarta/servlet/FilterChain, violationMessage=Could not find resource}
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=jakarta/servlet/ServletRequestListener, originalClass=jakarta/servlet/ServletRequestEvent, violationMessage=Could not find resource}
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=com/nr/instrumentation/servlet6/NRRequestWrapper, originalClass=jakarta/servlet/http/Cookie, violationMessage=Could not find resource}
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=jakarta/servlet/Servlet, originalClass=jakarta/servlet/ServletResponse, violationMessage=Could not find resource}
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=jakarta/servlet/ServletContextListener, originalClass=jakarta/servlet/ServletContextEvent, violationMessage=Could not find resource}
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=com/nr/instrumentation/servlet6/ServletHelper, originalClass=jakarta/servlet/AsyncContext, violationMessage=Could not find resource}
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=com/nr/instrumentation/servlet6/ServletHelper, originalClass=jakarta/servlet/ServletConfig, violationMessage=Could not find resource}
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=com/nr/instrumentation/servlet6/ServletHelper, originalClass=jakarta/servlet/FilterConfig, violationMessage=Could not find resource}
WeaveViolation{type=MISSING_ORIGINAL_BYTECODE, clazz=jakarta/servlet/http/HttpServlet}
WeaveViolation{type=MISSING_ORIGINAL_BYTECODE, clazz=jakarta/servlet/Servlet}
WeaveViolation{type=MISSING_ORIGINAL_BYTECODE, clazz=jakarta/servlet/ServletContextListener}
WeaveViolation{type=MISSING_ORIGINAL_BYTECODE, clazz=jakarta/servlet/ServletConnection}
WeaveViolation{type=MISSING_ORIGINAL_BYTECODE, clazz=jakarta/servlet/ServletRequestListener}
WeaveViolation{type=MISSING_ORIGINAL_BYTECODE, clazz=jakarta/servlet/ServletRequest}
WeaveViolation{type=MISSING_ORIGINAL_BYTECODE, clazz=jakarta/servlet/Filter}
WeaveViolation{type=MISSING_ORIGINAL_BYTECODE, clazz=jakarta/servlet/http/HttpServletResponse}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the :instrumentation:servlet-6.0:verifyPass_jakarta.servlet_jakarta.servlet-api_6.2.0-M1 task and the servlet-6.0 module. Reproduce the verification failure, then check whether the failure remains with the non-milestone jakarta.servlet-api release and whether the dependency range needs adjustment. Done means the module applies successfully and verification passes for the v6.2.0+ artifact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100