newrelic / newrelic/newrelic-java-agent
New Module: jsp-4 for v4.1+
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 240
- Forks
- 170
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 21
Description
Description
Probably worth validating that the failure still exists once the non-milestone artifact is released.
Execution failed for task ':instrumentation:jsp-4:verifyPass_jakarta.servlet.jsp_jakarta.servlet.jsp-api_4.1.0-M1'.
A failure occurred while executing com.newrelic.agent.instrumentation.verify.VerifyWorkAction
Verification FAILED. Instrumentation module jsp-4-1.0.jar SHOULD HAVE applied to jakarta.servlet.jsp:jakarta.servlet.jsp-api:4.1.0-M1 and did not. You may need to adjust the range "jakarta.servlet.jsp:jakarta.servlet.jsp-api:[4.0.0,)".
Verifier output:
Creating user classloader with custom classpath:
/home/runner/.gradle/caches/modules-2/files-2.1/jakarta.el/jakarta.el-api/6.0.0/c937953432d6811ce5a460b6ef90750beecb35c2/jakarta.el-api-6.0.0.jar
/home/runner/.gradle/caches/modules-2/files-2.1/jakarta.servlet/jakarta.servlet-api/6.1.0/1169a246913fe3823782af7943e7a103634867c5/jakarta.servlet-api-6.1.0.jar
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=com/nr/agent/instrumentation/jsp4/JspContextWrapper, originalClass=jakarta/servlet/jsp/JspWriter, violationMessage=Could not find resource}
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=com/nr/agent/instrumentation/jsp4/JspContextWrapper, originalClass=jakarta/servlet/jsp/JspContext, violationMessage=Could not find resource}
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=com/nr/agent/instrumentation/jsp4/PageContextWrapper, originalClass=jakarta/servlet/jsp/PageContext, violationMessage=Could not find resource}
WeaveViolation{type=MISSING_ORIGINAL_BYTECODE, clazz=jakarta/servlet/jsp/tagext/SimpleTagSupport}
WeaveViolation{type=MISSING_ORIGINAL_BYTECODE, clazz=jakarta/servlet/jsp/tagext/TagSupport}
WeaveViolation{type=MISSING_ORIGINAL_BYTECODE, clazz=jakarta/servlet/jsp/HttpJspPage}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by rerunning :instrumentation:jsp-4:verifyPass_jakarta.servlet.jsp_jakarta.servlet.jsp-api_4.1.0-M1 after the non-milestone artifact is available. Inspect the jsp-4 instrumentation and the range for jakarta.servlet.jsp:jakarta.servlet.jsp-api; done means verification applies to the 4.1+ API without the reported missing-bytecode violations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100