newrelic / newrelic/newrelic-java-agent
Vertx-postgres-sql v5.0.0 instrumentation module
Open
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 240
- Forks
- 170
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 21
Description
Description
A new module is required to support Vertx Postgres SQL v5.0.0. The verification for vertx-postgres-sqlclient-4.4.2 failed with:
Verification FAILED. Instrumentation module vertx-postgres-sqlclient-4.4.2-1.0.jar SHOULD HAVE applied to io.vertx:vertx-pg-client:5.0.0 and did not.
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=com/nr/vertx/sqlclient/instrumentation/SqlClientUtils, originalClass=io/vertx/sqlclient/impl/command/PrepareStatementCommand, violationMessage=Could not find resource}
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=com/nr/vertx/sqlclient/instrumentation/SqlClientUtils, originalClass=io/vertx/sqlclient/impl/command/CommandBase, violationMessage=Could not find resource}
ReferenceViolation{type=MISSING_ORIGINAL_BYTECODE, weaveClass=com/nr/vertx/sqlclient/instrumentation/SqlClientUtils, originalClass=io/vertx/sqlclient/impl/command/QueryCommandBase, violationMessage=Could not find resource}
WeaveViolation{type=MISSING_ORIGINAL_BYTECODE, clazz=io/vertx/sqlclient/impl/SqlClientBase}
WeaveViolation{type=MISSING_ORIGINAL_BYTECODE, clazz=io/vertx/sqlclient/impl/SqlClientBase$PreparedQueryImpl}
WeaveViolation{type=METHOD_NEW_CALL_ORIGINAL_UNSUPPORTED, clazz=io/vertx/pgclient/impl/PgSocketConnection, method=doSchedule(Lio/vertx/sqlclient/impl/command/CommandBase;Lio/vertx/core/Handler;)V}
WeaveViolation{type=METHOD_NEW_NON_PRIVATE_UNSUPPORTED, clazz=io/vertx/pgclient/impl/PgSocketConnection, method=doSchedule(Lio/vertx/sqlclient/impl/command/CommandBase;Lio/vertx/core/Handler;)V}
WeaveViolation{type=MISSING_ORIGINAL_BYTECODE, clazz=io/vertx/sqlclient/impl/SqlClientBase$QueryImpl}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue concerns the existing vertx-postgres-sqlclient-4.4.2 instrumentation and its failed verification against io.vertx:vertx-pg-client:5.0.0. Start by examining that instrumentation and the reported missing bytecode and method violations, then run verification for Vert.x 5.0.0. Done means the new module supports the version without those violations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- databases, observability
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 32/100