newrelic / newrelic/newrelic-java-agent
Remove File/Builder feature flag from Log4jLogManager
Open
Nobody has claimed this yet.
1
small
- Dominant language
- Java
- Stars
- 240
- Forks
- 170
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 21
Description
Description
For CrAC support, the configuration of the agent's root logger was moved to the Log4j Configuration Builder from a file based configuration. A FF flag was introduced to revert back to file based config in cause issues came up using the Builder. This FF needs to be removed after several months.
- Remove all file based config code from Log4jLogManager
- Remove FF check
- Remove
/META-INF/logging/log4j2.xmlfrom the project
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in Log4jLogManager and trace the file-based configuration and feature-flag check described in the issue. Remove those paths and the /META-INF/logging/log4j2.xml resource; done means the builder-based configuration remains without the fallback flag or file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- devtools
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100