neume-network / neume-network/data

green ring NFT on catalog has a duplicate

Open
#54 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
15
Forks
4
PR merge metrics
No merged PRs in 30d

Description

Greenring posted on Discord:

"""
Also, while I'm here, I have a specific question regarding making small corrections to neume. A duplicate of my song 'The Leap' was somehow minted by someone else on the catalog contract after me. Not really sure how it happened, but it went up right after I minted mine. I let catalog know, and it looks like they basically blanked out the NFT. The correct token ID on the Catalog contract for the song is 325, the fake one is 327. I only bring it up because there are currently two copies of the song showing on MusicOS so I'm guessing neume is indexing both. Just wondering if it is a straightforward or more involved fix to get neume to ignore this specific token.
Correct token:
https://opensea.io/assets/ethereum/0x0bc2a24ce568dad89691116d5b34deb6c203f342/325

Extra/Incorrect token:
https://opensea.io/assets/ethereum/0x0bc2a24ce568dad89691116d5b34deb6c203f342/327
"""

@il3ven commented:

"""
@TimDaub Upon a little inspection, I think this is because we fetch NFT on the block they were created. Catalog must have updated the tokenURI sometime after the mint. In neume, the tokenURI for tokenID 327 is still the old one.
"""

@il3ven do we need a "token ignore file" that we could e.g. set "0x0bc2a24ce568dad89691116d5b34deb6c203f342/325" to ignore?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the NFT fetching and indexing entry point described in the comments, focusing on tokenURI handling for catalog token 327. Determine how an ignore rule could distinguish the incorrect token from token 325, then verify that the duplicate no longer appears in MusicOS while the correct NFT remains indexed.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
blockchain, data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.