networkservicemesh / networkservicemesh/sdk-kernel

IP and policy removal not working on connection update

Open
#426 17 comments 0 reactions 1 assignee View on GitHub

@LionelJouin is already working on this.

Since Aug 23, 2022.

bug enhancement
Dominant language
Go
Stars
6
Forks
17
Avg merge
1h 37m
Merged PRs (30d)
5

Description

After some testing with this change: https://github.com/networkservicemesh/sdk/issues/1231. I found it was possible to add new IP addresses and policy routes by just requesting (updating) a new time without having to close the connection.

The issue I noticed is that it is not possible to remove any IP or policy route while they are removed from the IP context in the request.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.