networknt / networknt/light-codegen
The issue for the light-codegen for master branch (JDK11)
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 49
- Forks
- 25
- PR merge metrics
- No merged PRs in 30d
Description
If user use the supportDB config value in the config.json
"supportDb": true,
The light-codegen will generate datasource config in the service.yml:
'''
- javax.sql.DataSource:
- com.zaxxer.hikari.HikariDataSource:
DriverClassName:
jdbcUrl:
username:
password:
maximumPoolSize: 10
useServerPrepStmts: true
cachePrepStmts: true
cacheCallableStmts: true
prepStmtCacheSize: 10
prepStmtCacheSqlLimit: 2048
connectionTimeout: 2000
- com.zaxxer.hikari.HikariDataSource:
'''
And in the values.yml, light-codegen output:
service.singletons:
I think user may chose different ways for datasource, if user use light--4j data-source module,then it will use datasource.yml file and user can flexibly choose the way for database process.
So I would like suggest to remove the datasource in the setting in the service yam and change it to:
singletons: ${service.singletons:}
And user can only deal with on config file: values.yml
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace how the supportDb value from config.json produces the datasource section in service.yml and service.singletons in values.yml. Compare that output with the datasource.yml approach described in the issue, then verify that generated configurations use the requested singletons setting without the datasource block.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100