Move methods declared in SliceableFileRegion to FileRegion
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 35.1k
- Forks
- 16.3k
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 143
Description
This is a follow on work for #6997 which aims to add slice support for FileRegion. For keeping compatible, we can not add new methods directly to FileRegion as it is an interface, so a SliceableFileRegion interface is introduced. We should move all the methods declared in SliceableFileRegion to FileRegion when we are allowed to do incompatible changes, for example, when releasing netty 4.2?
And in the socket channel implementations, we need to write out FileRegion and SliceableFileRegion in different ways for now. We should also unify these after we move all the methods in SliceableFileRegion to FileRegion.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the FileRegion and SliceableFileRegion interfaces, then trace the socket channel implementations that currently write them differently. Confirm the incompatible-change policy for the target Netty release. Done means the methods are on FileRegion and socket channel handling is unified without retaining the temporary split.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, networking
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100