CLI installation with outdated Node erroneously reports success
Open
Nobody has claimed this yet.
type: bug
- Dominant language
- TypeScript
- Stars
- 1.9k
- Forks
- 474
- Avg merge
- 23h 30m
- Merged PRs (30d)
- 53
Description
Describe the bug
When attempting to install the CLI with an unsupported (outdated) version of node, you get the Success! Netlify CLI has been installed message before the installation actually fails.
internal link for context
Steps to reproduce
- Install node v12.10.0
npm i -g netlify-cli(in this case, it was 9.13.5)- 💥
Configuration
No response
Environment
❯ npx envinfo --system --binaries --npmPackages netlify-cli --npmGlobalPackages netlify-cli
System:
OS: macOS 12.3
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Memory: 5.48 GB / 32.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 14.18.3 - ~/.asdf/installs/nodejs/14.18.3/bin/node
Yarn: 1.22.17 - ~/.asdf/installs/nodejs/14.18.3/.npm/bin/yarn
npm: 8.4.0 - ~/.asdf/plugins/nodejs/shims/npm
npmGlobalPackages:
netlify-cli: 9.13.4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with Node v12.10.0 and npm i -g netlify-cli, then trace the CLI installation flow that prints the success message. Confirm the failure is reported before success, and rerun the installation with the supported Node environment shown in the issue to verify the corrected ordering.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js, typescript
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100