Include default requests/limits for child pods
Nobody has claimed this yet.
- Dominant language
- Go Template
- Stars
- 177
- Forks
- 81
- Avg merge
- 5h 48m
- Merged PRs (30d)
- 5
Description
Since a good deal of netdata's value is in keeping its' footprint as small as possible, and instances are stateless, adding default limits for child pods seem to make sense. I would include parent and k8s-state too, but AFAIK those are relative to the size/complexity of the cluster and therefore hard to predict.
Setting resource requests is just good practice. Setting limits prevent runaway processes.
Based on the docs I suggest defaulting the child to
resources:
requests:
cpu: 150m
memory: 200Mi
limits:
memory: 250Mi
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Helm chart template or values entry that configures child pods, then compare the proposed defaults with the linked resource documentation. Done means rendered child pods include 150m CPU and 200Mi memory requests, plus a 250Mi memory limit; verify the chart output if tests or rendering checks are available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- helm, kubernetes
- Domain
- infrastructure
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100