nestybox / nestybox/sysbox

Libseccomp removal caused failure in runc in Makefile in rpm builds

Open
#748 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
3.9k
Forks
230
Avg merge
7h 48m
Merged PRs (30d)
3

Description

Full logs are available here: https://download.copr.fedorainfracloud.org/results/karellen/karellen-sysbox/fedora-38-x86_64/06680595-karellen-sysbox/builder-live.log.gz

Do I need to depend on the system's libseccomp[-devel] now?

make[1]: Leaving directory '/builddir/build/BUILD/karellen-sysbox-0.6.2.30/sysbox/sysbox-ipc'
make[1]: Entering directory '/builddir/build/BUILD/karellen-sysbox-0.6.2.30/sysbox/sysbox-runc'
fatal: not a git repository (or any of the parent directories): .git
/bin/sh: line 1: lsmod: command not found
/bin/sh: line 1: lsmod: command not found
CGO_ENABLED=1  go build -buildvcs=false -trimpath  -tags "seccomp apparmor idmapped_mnt netgo osusergo" -ldflags "-extldflags -static -X 'main.edition=Community Edition (CE)' -X main.version=0.6.2 -X main.commitId= -X 'main.builtAt=Wed Nov 22 17:39:46 UTC 2023' -X 'main.builtBy='" -o build/amd64/sysbox-runc .
go: downloading github.com/checkpoint-restore/go-criu/v4 v4.1.0
go: downloading github.com/containerd/console v1.0.1
go: downloading github.com/coreos/go-systemd/v22 v22.1.0
go: downloading github.com/docker/go-units v0.4.0
go: downloading github.com/opencontainers/runtime-spec v1.1.1-0.20230823135140-4fec88fd00a4
go: downloading github.com/opencontainers/selinux v1.8.0
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/pkg/profile v1.5.0
go: downloading github.com/sirupsen/logrus v1.9.0
go: downloading github.com/urfave/cli v1.22.1
go: downloading golang.org/x/sys v0.0.0-20220722155257-8c9f86f7a55f
go: downloading github.com/docker/docker v20.10.2+incompatible
go: downloading github.com/Masterminds/semver v1.5.0
go: downloading github.com/cyphar/filepath-securejoin v0.2.2
go: downloading github.com/golang/protobuf v1.4.3
go: downloading github.com/moby/sys/mountinfo v0.4.0
go: downloading github.com/mrunalp/fileutils v0.5.0
go: downloading github.com/vishvananda/netlink v1.1.0
go: downloading github.com/godbus/dbus/v5 v5.0.3
go: downloading github.com/willf/bitset v1.1.11
go: downloading github.com/deckarep/golang-set/v2 v2.3.1
go: downloading github.com/deckarep/golang-set v1.7.1
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0-20190314233015-f79a8a8ca69d
go: downloading google.golang.org/protobuf v1.25.0
go: downloading github.com/joshlf/go-acl v0.0.0-20200411065538-eae00ae38531
go: downloading github.com/karrick/godirwalk v1.16.1
go: downloading github.com/seccomp/libseccomp-golang v0.10.0
go: downloading github.com/vishvananda/netns v0.0.0-20191106174202-0a2b9b5464df
go: downloading google.golang.org/grpc v1.34.1
go: downloading github.com/spf13/afero v1.4.1
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading github.com/docker/go-connections v0.4.0
go: downloading github.com/opencontainers/image-spec v1.0.1
go: downloading github.com/containerd/containerd v1.4.12
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: downloading github.com/opencontainers/go-digest v1.0.0
go: downloading github.com/cilium/ebpf v0.3.0
go: downloading golang.org/x/net v0.0.0-20220722155237-a158d28d115b
go: downloading google.golang.org/genproto v0.0.0-20200526211855-cb27e3aa2013
go: downloading golang.org/x/text v0.3.8
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading github.com/gogo/protobuf v1.3.2
# pkg-config --cflags  -- libseccomp
Package libseccomp was not found in the pkg-config search path.
Perhaps you should add the directory containing `libseccomp.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libseccomp', required by 'virtual:world', not found
pkg-config: exit status 1
make[1]: Leaving directory '/builddir/build/BUILD/karellen-sysbox-0.6.2.30/sysbox/sysbox-runc'
make[1]: *** [Makefile:169: static] Error 2
make: *** [Makefile:232: sysbox-runc-static] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.BawSC8 (%build)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the sysbox-runc Makefile targets at lines 169 and 232 and review the RPM build log, especially the pkg-config failure for libseccomp. Determine whether the static build should use a system libseccomp dependency or another declared build input. Done means the RPM build completes without the reported libseccomp error.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.