nestjs / nestjs/graphql

Apollo + Fastify version conflicts

Open
#3,554 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug needs triage
Dominant language
TypeScript
Stars
1.6k
Forks
432
Avg merge
2d 6h
Merged PRs (30d)
26

Description

Is there an existing issue for this?
  • I have searched the existing issues
Current behavior

Trying to upgrade nestjs to latest versions I encounter peer deps conflicts.
I am using fastify, so I have @nestjs/platform-fastify installed.
upgraded to v11 it has a peer dep to "fastify": "5.3.0".

I upgraded @nestjs/apollo to 13.1.0.
it has a peer dep to @as-integrations/fastify: 2.1.1

@as-integrations/fastify has not been updated for the past 2 years.
It has a peer dependency to "fastify": "^4.4.0".

Running the server without @as-integrations/fastify breaks with an error The "@as-integrations/fastify" package is missing. Please, make sure to install it to take advantage of GraphQLModule from this line(https://github.com/nestjs/graphql/blob/master/packages/apollo/lib/drivers/apollo-base.driver.ts#L179)

However the @nestjs/apollo documentation doesn't even mention this lib: https://www.npmjs.com/package/@nestjs/apollo instead asking to install apollo-server-fastify which has been deprecated (https://www.npmjs.com/package/apollo-server-fastify)

If there is any alternative, please suggest it, otherwis issue a breaking change to the latest versions describing that apollo no longer supports fastify.

Minimum reproduction code

https://www.npmjs.com/package/apollo-server-fastify

Steps to reproduce

npm i @nestjs/platform-fastify
npm i @nestjs/apollo
npm I fastify
npm i @as-integrations/fastify OR npm i apollo-server-fastify

Expected behavior

either remove @as-integrations/fastify dependency or deprecate fastify

Package version

13.1.0

Graphql version

graphql: 16.10.0
apollo-server-express: NA
apollo-server-fastify: 3.13.0

NestJS version

11.0.16

Node.js version

v20.18.1

In which operating systems have you tested?
  • macOS
  • Windows
  • Linux
Other

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with packages/apollo/lib/drivers/apollo-base.driver.ts at the referenced line, then compare the @nestjs/apollo documentation with the listed Fastify integration packages and peer dependency versions. Reproduce the installation and startup steps to confirm the conflict; done means the supported Fastify/Apollo path and any required breaking-change documentation are consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
graphql, node.js, typescript
Domain
api, backend, backend-api-design
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.