neos / neos/redirecthandler-ui
Allow for Colon (":") in Source URI Path
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13
- Forks
- 17
- PR merge metrics
- No merged PRs in 30d
Description
Greetings!
When trying to add a source URI path containing a colon (:) through the backend module the validation fails, because it is not allowed in the regex /^[a-z0-9_\-\/\.%]+$/i.
It is possible to do it via commands:
./flow redirect:add --source 'category/subject:mysubject' --target 'category/subject:othersubject'
Although the colon is used in URIs for the protocol (like https://) or the port (like :80), it appears to be fine for usage in the URI path.
Related: In https://github.com/neos/redirecthandler-ui/issues/101 it was proposed to have the regex only in one place, not two.
Thank you.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the backend module validation that uses /^[a-z0-9_\-\/%]+$/i and compare it with the command entry point ./flow redirect:add. Check the related issue 101 for the duplicated-regex context. Done means source URI paths containing : are accepted through the backend while existing URI validation remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100