neos / neos/BuildEssentials

ComposerManifestMerger needs to check version numbers.

Open
#29 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
9
Forks
10
PR merge metrics
No merged PRs in 30d

Description

The ComposerManifestMerger currently just merges same package requires together regardless of the version, last wins. This should be changed to check versions and result in the highest version being actually required in the merged manifest (+ maybe a warning/notice output about the fact that multiple vesions were required).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the ComposerManifestMerger entry point and inspect how same-package requirements are currently combined. Reproduce a merge with differing version requirements, then verify that the merged manifest requires the highest version and determine whether the optional warning or notice is covered by existing tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
build-system, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.