nebula-plugins / nebula-plugins/nebula-release-plugin
Bug forcing tag naming strategy with prefix v
Nobody has claimed this yet.
- Dominant language
- Groovy
- Stars
- 236
- Forks
- 60
- Avg merge
- 10m
- Merged PRs (30d)
- 4
Description
From version 18.0.6 and so on the NearestVersionLocator only read tags that use v as prefix, as you can see in this commit:
https://github.com/nebula-plugins/nebula-release-plugin/commit/7d369f630fd937d7069e5c50857089e052ebf1e4
But the base plugin gradle-git allow users to extend the tagStrategy to define how the git tag will be created, through setting:
#build.gradle
release {
tagStrategy {
prefixNameWithV = false
}
}
or
#build.gradle
release {
tagStrategy {
toTagString = { version -> "${version}" }
}
}
Shouldn't it to be consider as a bug?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/main/groovy/nebula/plugin/release/git/command/GitReadCommand.groovy at the cited line and inspect commit 7d369f630fd937d7069e5c50857089e052ebf1e4. Compare NearestVersionLocator's tag lookup with the configurable tagStrategy examples in the issue; done means custom strategies such as prefixNameWithV = false or toTagString are respected when locating tags.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git
- Domain
- build-system, release
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100