nebula-plugins / nebula-plugins/nebula-release-plugin

Hyphen sandwiched by underscores in branch name results in "An exception occurred applying plugin request [id: 'java']"

Open
#237 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Groovy
Stars
236
Forks
60
Avg merge
10m
Merged PRs (30d)
4

Description

id 'nebula.release' version '15.0.0'

Error message does say

An exception occurred applying plugin request [id: 'java']
  > Failed to apply plugin 'org.gradle.java'.
   > Could not create domain object 'test' (JvmTestSuite)
...
 Exception is:
org.gradle.api.plugins.InvalidPluginException: An exception occurred applying plugin request [id: 'java']
...
Caused by: org.gradle.api.internal.plugins.PluginApplicationException: Failed to apply plugin 'org.gradle.java'.
...
Caused by: java.lang.IllegalStateException: Could not create domain object 'test' (JvmTestSuite)
...
Caused by: Identifiers MUST NOT be empty (Unexpected character 'DOT(.)' at position '105', expecting '[DIGIT, LETTER, HYPHEN]')

but this message doesn't give you an idea that this issue is related to a branch name

Good branch name: feature/BLABLA-1000_This_branch-will_work
Bad branch name: feature/BLABLA-1000_This_branch_-_will_fail

Please, update error message to point that issue is in branch name or let it support _-_ in branch name

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failure with the good and bad branch names in the issue, then trace the branch-name handling that leads to the InvalidPluginException. Done means the _-_ case is supported or the resulting error clearly identifies the branch name as the cause.

Written by the indexing model from the issue text.

Assessment

Tech stack
groovy
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.