nebari-dev / nebari-dev/rayserve-pack

rendered chart is never checked for correctness in CI

Open
#39 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Makefile
Stars
1
Forks
4
Avg merge
3d 14h
Merged PRs (30d)
5

Description

Surfaced in https://github.com/nebari-dev/rayserve-pack/pull/38/changes#r3881960421.

https://github.com/nebari-dev/rayserve-pack/blob/00401301e41ed06cae1537d34a430218d61118ed/.github/workflows/lint.yaml#L24-L42

All three steps just run helm template, which only fails if the output is not valid YAML. It doesn't assert anything about the output being correct.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with .github/workflows/lint.yaml at lines 24-42 and inspect the three helm template steps. Determine how the rendered chart should be checked beyond valid YAML, then add CI validation for the expected output. Done means the workflow detects an incorrect rendered chart, not only malformed YAML.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm
Domain
ci-cd, devops
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.