nebari-dev / nebari-dev/llm-serving-pack
Converge LLMModel reconciler onto the PassthroughModel gateway-apply failure handling
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 3
- Forks
- 3
- Avg merge
- 16h 31m
- Merged PRs (30d)
- 11
Description
The PassthroughModel reconciler treats a failed AI-Gateway-resource apply (e.g. CRDs not yet installed) as an ApplyFailed condition + Error phase + one-minute requeue (passthroughmodel_controller.go:131). The older LLMModel reconciler logs-and-continues for the identical case (llmmodel_controller.go:445-470, "CRD may not be installed, skipping") with no Error phase and no requeue.
The surface-and-requeue behavior is the better of the two and is now documented in design.md as the intended operator-wide convention. This issue tracks converging the LLMModel path onto it so the operator handles the same situation one way.
Surfaced in review of #96.
Acceptance
- LLMModel reconciler sets an
ApplyFailedcondition and requeues on a degraded gateway apply - Existing LLMModel tests updated
- Behavior matches the convention documented in
design.md
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare passthroughmodel_controller.go:131 with llmmodel_controller.go:445-470, then read the existing LLMModel tests and the convention in design.md. Update the LLMModel path so degraded gateway applies produce an ApplyFailed condition and requeue, and confirm the tests cover the matching behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- infrastructure
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100