nebari-dev / nebari-dev/data-science-pack
PR-build sha- image tags name the merge commit, so in-PR pins can silently go stale
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 5
- Forks
- 7
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 13
Description
On pull_request events, build-image.yaml tags pushed images with type=sha computed from the merge commit, not the head commit. Two consequences:
- A pin committed inside the PR (the
values.yamlbump that points e2e at the PR build) can never name the build of the commit that contains it — the pin has to be added after the build, pointing at an earlier merge-commit sha. - Any subsequent push touching
images/**builds a new sha whilevalues.yamlstill pins the old one, so e2e goes green against stale image content with no signal anywhere.
https://github.com/nebari-dev/data-science-pack/pull/241 dodged this only by ordering the pin as the last commit. Possible directions: have e2e fail if the pinned sha does not correspond to the current head's build, tag PR builds with the head sha as well, or have a workflow re-sync the pin on each push.
Raised in review of https://github.com/nebari-dev/data-science-pack/pull/241#pullrequestreview-5054401295.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with .github/workflows/build-image.yaml and the values.yaml pin used by e2e; trace how pull_request builds derive their image tags and how later changes under images/** affect the pin. Compare the possible approaches in the issue, then verify that a subsequent push cannot leave e2e silently using stale image content.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions
- Domain
- ci-cd, devops
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100